-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO library #483
Comments
Hi, I want to clean up a little bit the pr list. I think I understand why this is stalled. My po is that the 3rd option you mention is the best one. However I think that pr shouldn't be kept there for that long. What do you guys think we should do with the pr?
|
Yes, Simon's PR has been around for some time now. I think the tool works and it could be used to convert fiff to edf as is. We wrote that tool for the BCH people to use. Maybe for now and until we know how to handle data, copy the branch to your private repo (just in case Simon deletes it at some point) and close the PR. |
Why not create a dev branch in this mne-cpp repository? |
The idea with the current approach ist not to pollute the main repository with not supported and unstable code which does not build. This is a matter of keeping the (central) main repo clean. Technically we already have a dev branch. The current master branch can be understood as our dev branch on which we work until we do a new release. New releases are then branched off if it was a major version release. For example if we would go from v0.1.8 to v.0.2.0 a new branch will be created. You can check out popular projects (mne-python, scikit-learn, etc.) which we used as an inspiration when we came up with MNE-CPP's release cycle early 2020. Speaking of branches, we should maybe have this discussion for MNE-CPP as well: mne-tools/mne-python#7901 |
With regard to PR #397 we should start thinking about how we want to support different file formats. I see three options right now:
Last option is quite invasive and will lead to a considerable work load. Not sure if it's worth it.
The text was updated successfully, but these errors were encountered: