You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@wmvanvlietEvokedField._on_colormap_range has a comparison if type == "meg", but type here is the builtin type rather than something passed by kwarg for example:
Bonus points for removing these shadowing of builtins, it's a reason we generally prefer stuff like type_ to type when not use the builtin -- the flake / ruff check would have caught this issue then!
The text was updated successfully, but these errors were encountered:
@wmvanvliet
EvokedField._on_colormap_range
has a comparisonif type == "meg"
, buttype
here is the builtintype
rather than something passed by kwarg for example:mne-python/mne/viz/evoked_field.py
Line 476 in 16c17b4
When you get a chance can you fix this?
Bonus points for removing these shadowing of builtins, it's a reason we generally prefer stuff like
type_
totype
when not use the builtin -- theflake
/ruff
check would have caught this issue then!The text was updated successfully, but these errors were encountered: