Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: flake in code due to shadowing of builtin #12352

Closed
larsoner opened this issue Jan 11, 2024 · 0 comments · Fixed by #12354
Closed

BUG: flake in code due to shadowing of builtin #12352

larsoner opened this issue Jan 11, 2024 · 0 comments · Fixed by #12354

Comments

@larsoner
Copy link
Member

@wmvanvliet EvokedField._on_colormap_range has a comparison if type == "meg", but type here is the builtin type rather than something passed by kwarg for example:

if type == "meg":

When you get a chance can you fix this?

Bonus points for removing these shadowing of builtins, it's a reason we generally prefer stuff like type_ to type when not use the builtin -- the flake / ruff check would have caught this issue then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant