[MRG] ENH: add skip_by_annotation to notch_filter #11388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmainak
force-pushed
the
skip_annot_filter
branch
9 times, most recently
from
80896ac to
4782426
Compare
jasmainak
changed the title
jasmainak
force-pushed
the
skip_annot_filter
branch
from
4782426 to
2d1f6a2
Compare
jasmainak
changed the title
|
Is there a way to make the length of the notch filter shorter @larsoner ? Even though I have implemented this, it's pretty useless for my data since the ISI is around 300-500 ms with a stim artifact that I want to skip with annotations. Alternatively, would it make sense to concatenate the segments before filtering? |
|
You can set |
jasmainak
force-pushed
the
skip_annot_filter
branch
from
2d1f6a2 to
3eab3c8
Compare
jasmainak
changed the title
|
Thanks for the suggestion! That sounds fair, so I changed the PR status to MRG again. |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jan 4, 2023
* upstream/main: [MRG] ENH: add skip_by_annotation to notch_filter (mne-tools#11388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #10447
This adds a
skip_by_annotationfor notch filtering