Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Create a Calibrations class for eyetracking data #11719
ENH: Create a Calibrations class for eyetracking data #11719
Changes from 48 commits
5fb94fd
444f6d8
48a946c
000bc5c
1863b24
e1115c1
ea80885
7fac97e
71ccbac
2bfff19
ec13a2b
1d09b00
dd25b35
ca01ed8
f484759
90fbdd2
604e981
57339b9
03f5b6b
39d9357
156c2bd
e5fecea
ebcd020
87320fb
781bc6f
ca9b156
5015c9b
17eca8d
296794b
11ec6b8
cda0e09
328c505
ccbd5ec
e821ffe
f1c2c9d
6f1cffd
2853dff
4938d59
2dee68e
ca9157d
c972567
d71709b
143c583
6ede0af
b256454
cd3b34a
c0f8bac
48fdd2e
5b437fa
86d0138
1184215
5781a59
c7d7dd9
0e5133c
3d5d5d7
073fba9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
Notes
section mentioning that gaps between recording blocks will be annotated withBAD_ACQ_SKIP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
_
-prefixed attributes should be documented in the class doc. Feel free to move these to code comments if you want, though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll go through and remove these from the
read_raw_eyelink
docstring.