Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer links #11729

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

mscheltienne
Copy link
Member

@mscheltienne mscheltienne commented Jun 12, 2023

@mscheltienne mscheltienne enabled auto-merge (squash) June 12, 2023 13:00
@mscheltienne mscheltienne merged commit 959d2b6 into mne-tools:main Jun 12, 2023
larsoner pushed a commit that referenced this pull request Jun 12, 2023
@larsoner
Copy link
Member

Argh sorry, I really need to check those better before committing and after deployment!

@mscheltienne mscheltienne deleted the fix_installers branch June 12, 2023 15:03
@mscheltienne
Copy link
Member Author

No problem but shouldn't this be picked-up by the workflow linkcheck?

@larsoner
Copy link
Member

I suspect linkcheck only uses links created by RST-to-html conversion, and these are in raw HTML blocks. I doubt they parse raw HTML blocks (or the output HTML itself) to find the links to check...

@mscheltienne
Copy link
Member Author

Arf too bad 😞 maybe worth a small extra step to parse installers.rst, get the links and check them

larsoner added a commit to larsoner/mne-python that referenced this pull request Jun 23, 2023
* upstream/main: (24 commits)
  Allow int-like as ID of make_fixed_length_events (mne-tools#11748)
  Easycap-M43 montage (mne-tools#11744)
  ENH: Create a Calibrations class for eyetracking data (mne-tools#11719)
  Fix alphabetical order in overview/people.rst, fix sphinx formatting in docstrings and set verbose to keyword-only (mne-tools#11745)
  Add Mathieu Scheltienne to MNE-Python Steering Council (mne-tools#11741)
  removed requirement for curv.*h files to create Brain object (mne-tools#11704)
  [BUG] Fix mne.viz.Brain.add_volume_labels matrix ordering bug (mne-tools#11730)
  Fix installer links (mne-tools#11729)
  MAINT: Update for PyVista deprecation (mne-tools#11727)
  MAINT: Update roadmap (mne-tools#11724)
  MAINT: Update download link [skip azp] [skip cirrus] [skip actions]
  fix case for chpi_info[1] == None (mne-tools#11714)
  Add cmap argument for mne.viz.utils.plot_sensors (mne-tools#11720)
  BUG: Fix one more PySide6 bug (mne-tools#11723)
  MAINT: Fix PySide6 and PyVista compat (mne-tools#11721)
  MRG: If _check_fname() cannot find a file, display the path in quotation marks to help spot accidental trailing spaces (mne-tools#11718)
  Add "array-like" to `_validate_type()` (mne-tools#11713)
  MAINT: Avoid problematic PySide6 (mne-tools#11715)
  Fix installer links (mne-tools#11709)
  Updating change log after PR mne-tools#11575 (mne-tools#11707)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants