Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: EEG eye-tracking alignment tutorial #11770
DOC: EEG eye-tracking alignment tutorial #11770
Changes from 24 commits
7e98d82
f77b567
d16adea
13fba79
4ebe2bf
c511e29
480c432
c2b39b7
c3bf604
1f0e3dc
f9fd97b
03807fc
3ff5869
cfcd5cd
fcd6e48
12d421f
c639496
3f1f981
6b58bce
9963bcc
1d59f59
e86c335
b37c068
1e618aa
2718b66
bf1439c
ecbe00b
0067585
115e821
102e0dd
f206d18
86f484b
b3141c3
685c2cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm questioning whether this additional explanation is worth it. Is the custom dict approach better than passing
scalings="auto"
? Is it something most users will want to do? I think with"auto"
parameter values it's kinda OK to not explain them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the custom scalings result in a much nicer plot than auto, but I included this bit about using "auto", in case any non-powerusers wanted a simpler way than passing a dict.