Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle scaling issues when changing Canvas RenderMode #9

Closed
theKin opened this issue Nov 20, 2018 · 8 comments
Closed

Particle scaling issues when changing Canvas RenderMode #9

theKin opened this issue Nov 20, 2018 · 8 comments
Assignees
Labels
question Further information is requested

Comments

@theKin
Copy link

theKin commented Nov 20, 2018

Hi

Thank you for releasing the awesome UI Particle plug-in,
and please understand that my English is awkward.

There is something that seems to be a bit of a problem when I test it.

I opened the project that I uploaded as an example to Unity (2018.2.5f1) and it worked without any problem. However, changing the Canvas's RenderMode to ScreenSpace-Overlay did not seem to work.

I thought it was a problem in the UIParticle.cs to call the BakeMesh function with the Camera as an argument even though it was not based on CameraRenderMode. In fact, it was too small to render.

To make it work as intended, I need to raise the Scale of the RectTransform to 60, as in the example in ConvertParticlesToUIVertex.

I wonder if the intended behavior is correct.

@mob-sakai mob-sakai added the question Further information is requested label Nov 20, 2018
@mob-sakai mob-sakai self-assigned this Nov 20, 2018
@mob-sakai
Copy link
Owner

Hi @theKin

Thank you for using this plugin.

I have heard of this issue before.
I hope #8 will be of help to you.

Can you submit a reproducible project for this issue?

@theKin
Copy link
Author

theKin commented Nov 21, 2018

I tested it in the example scene included in the plug-in that you uploaded to gitHub.

So if it's an issue like # 8,
When I change the RenderMode of Canvas to ScreenSpace-Overlay, do I understand that I am directly changing the scale of the RectTransform?

@mob-sakai
Copy link
Owner

Oh, I get it.
As you say, the particles are so small that they can not be seen.
It looks like a bug.

@mob-sakai mob-sakai added the bug Something isn't working label Nov 21, 2018
@mob-sakai
Copy link
Owner

Umm, It is difficult issue...

@mob-sakai
Copy link
Owner

Most particle effects consist of multiple ParticleSystems.
Changing the all Transform.localScale for scaling particles is a bother, and may not result in correct results.

I think that it is necessary to have a "scale" independent from ParticleSystem.StartSize and Transform.localScale.

@mob-sakai
Copy link
Owner

[WIP] Scaling by transform vs scaling by post scale


Smoke trails are incorrect.


Good scaling!

@theKin
Copy link
Author

theKin commented Nov 27, 2018

So cool!
I'll wait for post scale version. :)

@mob-sakai mob-sakai removed the bug Something isn't working label Nov 28, 2018
@mob-sakai
Copy link
Owner

v1.1.0 has been released!
Release page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants