onBecome(Un)Observed didn't trigger when use number as key of observable map

[wayne-liberty]

[x] Issue:

• a minimal sample reproduction. sandbox
• Elaborate on your issue. What behavior did you expect?

when use number as key of observable map, onBecomeObserved didn't trigger callback, but it worked fine when using string as key

• State the versions of MobX and relevant libraries. Which browser / node / ... version?

mobx: 5.13.0

[urugator]

I think the problem is here:

mobx/src/api/become-observed.ts

Lines 50 to 51 in ec011d5

	typeof arg2 === "string" ? getAtom(thing, arg2) : (getAtom(thing) as any)
	const cb = typeof arg2 === "string" ? arg3 : arg2

It should go like:

const atom: IObservable =
   typeof arg3 === "function" ? getAtom(thing, arg2) : (getAtom(thing) as any)
const cb = typeof arg3 === "function" ? arg3 : arg2

PR welcome

[wayne-liberty]

ok, I'll try

[wayne-liberty]

PR is made: #2073. It's my first time doing PR, please help review.

[danielkcz]

PRs merged for both versions #2073 #2075

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.