Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better CORS defaults for SSE transport #143

Open
jspahrsummers opened this issue Feb 3, 2025 · 2 comments
Open

Better CORS defaults for SSE transport #143

jspahrsummers opened this issue Feb 3, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@jspahrsummers
Copy link
Member

jspahrsummers commented Feb 3, 2025 •
edited
Loading

It's likely that most MCP servers accessible over SSE should be contactable by frontend web applications, which means the right CORS headers need to be set. The SDK should likely opt-in to this by default, with an opt-out available.

See also modelcontextprotocol/python-sdk#187.
@jspahrsummers jspahrsummers added the enhancement New feature or request label Feb 3, 2025
@jspahrsummers jspahrsummers mentioned this issue Feb 3, 2025
Open
@Vikrant-Khedkar
Copy link

Hey, I am interested in fixing this. would love to discuss more

@punkpeye
Copy link

For what it is worth, https://github.com/punkpeye/fastmcp defaults to allowing CORS by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jspahrsummers @Vikrant-Khedkar @punkpeye