Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Compilation with CMake #5

Closed
slamer59 opened this issue Nov 21, 2017 · 4 comments
Closed

Cross Compilation with CMake #5

slamer59 opened this issue Nov 21, 2017 · 4 comments

Comments

@slamer59
Copy link

slamer59 commented Nov 21, 2017

Cmake is designed to build, test and package software.
Add a cmake to streamline the code generation for multiple platforms is an approach

CoolProp developpement shows how to build static library from it

The same approach can be seen here

Compiled library will be installed in Resources/Library following suggestion #4 (comment).

@jowr
Copy link
Collaborator

jowr commented Nov 21, 2017

I guess this one is obsolete soon since #6 already contains my changes that introduced CMake. However, my code was written in a hurry and I would appreciate if you had a look at it.

@slamer59
Copy link
Author

It is a good starting point to reach the objective by the end of the year.

For an enhancement, all commands in .bat file and .sh in ExternalMedia/Projects/ may be integrated in CMakeLists.txt. It will be easier to maintain one file for cmake than 10 specific files for specific compilation.

We can build a more robust cross compilation process integrating all those command in CMake:

  • FindGit.cmake helps to find git and will replace all commands like git clone, git pull,...
  • CFLAGS will replace for example C_OPTS, i.e. GCC_OPTS, variable in .bat file, .i.e .sh file
  • file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/ DESTINATION ${CMAKE_CURRENT_BINARY_DIR}) to replace copy or cp command
  • ...

I guess all specific compilation option will be handle by hand or by TravisCI system.

@jowr
Copy link
Collaborator

jowr commented Nov 21, 2017

Yes, but we still have to decide whether we want to use CoolProp as a submodule in git or as an external CMake project (ExternalProject_Add). I think we should try to avoid calling git manually :-)

@slamer59
Copy link
Author

@jowr, I think this is not related to CMake
So I open a specific subject #8

@jowr jowr mentioned this issue Dec 22, 2020
@beutlich beutlich linked a pull request Dec 22, 2020 that will close this issue
@jowr jowr mentioned this issue Jan 6, 2021
@jowr jowr closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants