From 9118c648900cab0a9a414d2dff848b05b1b1bb71 Mon Sep 17 00:00:00 2001
From: Mikhail Bashkirov <bashmish@gmail.com>
Date: Mon, 15 Apr 2024 15:38:13 +0200
Subject: [PATCH] fix(storybook-builder): clean up NODE_PATH from bundled
 modules output

---
 .changeset/fuzzy-poems-decide.md                     |  5 +++++
 .../src/rollup-plugin-prebundle-modules.ts           | 12 +++++++++---
 2 files changed, 14 insertions(+), 3 deletions(-)
 create mode 100644 .changeset/fuzzy-poems-decide.md

diff --git a/.changeset/fuzzy-poems-decide.md b/.changeset/fuzzy-poems-decide.md
new file mode 100644
index 000000000..3630d960e
--- /dev/null
+++ b/.changeset/fuzzy-poems-decide.md
@@ -0,0 +1,5 @@
+---
+'@web/storybook-builder': patch
+---
+
+clean up NODE_PATH from bundled modules output
diff --git a/packages/storybook-builder/src/rollup-plugin-prebundle-modules.ts b/packages/storybook-builder/src/rollup-plugin-prebundle-modules.ts
index 10eda33ca..1410f2b2c 100644
--- a/packages/storybook-builder/src/rollup-plugin-prebundle-modules.ts
+++ b/packages/storybook-builder/src/rollup-plugin-prebundle-modules.ts
@@ -42,9 +42,15 @@ export function rollupPluginPrebundleModules(env: Record<string, string>): Plugi
             '@storybook/react-dom-shim': getReactDomShimAlias(),
           }),
         },
-        define: {
-          ...stringifyProcessEnvs(env),
-        },
+        define: (() => {
+          const define = stringifyProcessEnvs(env);
+
+          // "NODE_PATH" pollutes the output, it's not used by prebundled modules and is not recommended in general
+          // see more https://github.com/nodejs/node/issues/38128#issuecomment-814969356
+          delete define['process.env.NODE_PATH'];
+
+          return define;
+        })(),
         plugins: [
           esbuildPluginCommonjsNamedExports(
             modules.filter(