Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: silently closing threads not working as intended #3214

Closed
livvie0001 opened this issue Oct 4, 2022 · 4 comments
Closed

[BUG]: silently closing threads not working as intended #3214

livvie0001 opened this issue Oct 4, 2022 · 4 comments
Labels
maybe: bug An unconfirmed bug

Comments

@livvie0001
Copy link

Bot Version

4.0.1

How are you hosting Modmail?

Heroku

Error Logs

https://hastebin.cc/oreyuqifum

Screenshots

F1722545-B9E3-486B-A1BC-BAB369465978

Additional Information

When using silent close as instructed in the help menu, the thread is closed with the message ‘silently’ rather than closing silently as intended. Placing ‘silently’ before the timeframe works as intended.

@livvie0001 livvie0001 added the maybe: bug An unconfirmed bug label Oct 4, 2022
@lidistat67
Copy link
Contributor

The command does not work like that. You only need to provide the hour. So for example ?close 12h This thread has been closed for inactivity would close the thread in 12 hours and provide the message "This thread has been closed for inactivity"

@Jerrie-Aries
Copy link
Contributor

It used to work on older version tho.
close_silent

And as she said there the help menu says otherwise:

When using silent close as instructed in the help menu ...

help_close

It may need to be updated.
Just flip the in 10m silently to silently in 10m.

@lidistat67
Copy link
Contributor

Thank you both. I've made a pull request :)

@Taaku18
Copy link
Collaborator

Taaku18 commented Dec 19, 2022

PR #3215 fixes the order in the help example. Maybe in the future, we'll support in 10m silently format.

@Taaku18 Taaku18 closed this as completed Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe: bug An unconfirmed bug
Projects
None yet
Development

No branches or pull requests

4 participants