Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: No module named architectures #286

Open
gnodar01 opened this issue Jan 30, 2025 · 1 comment
Open

[BUG]: No module named architectures #286

gnodar01 opened this issue Jan 30, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@gnodar01
Copy link

gnodar01 commented Jan 30, 2025

Bug description

Following the README in examples/pipelines:

  ~/max/examples/pipelines   main ❯ magic run text_generation
Traceback (most recent call last):
  File "/home/ngogober/max/examples/pipelines/text_generation.py", line 18, in <module>
    from architectures import register_all_models
ModuleNotFoundError: No module named 'architectures'

I have not modified the pixi.toml, but here is the contents:

[project]
authors = ["Modular <[email protected]>"]
channels = ["conda-forge", "https://conda.modular.com/max-nightly/"]
description = "Examples exercising the max pipelines in python"
name = "Python Pipelines Examples"
platforms = ["osx-arm64", "linux-aarch64", "linux-64"]
version = "0.1.0"

[tasks]
text_generation = "python text_generation.py"

[dependencies]
python = ">=3.9,<3.13"
max = ">=24.6.0.dev2024090821"

[pypi-dependencies]
tqdm = ">=4.66.5"

It doesn't have any architectures module in its dependencies, so makes sense that it wouldn't find it.

Steps to reproduce

Steps to reproduce:

  • Run magic run text_generation
  • get error

System information

  • What OS did you do install MAX on ?

Shouldn't matter for this issue, but Ubuntu

  • Provide version information for MAX by pasting the output of max -v`

The python package max is indeed in my site-packages and importable within python, but there is no cli command max available, and in python import max; print(max.__version__) has no result.

The max repo is on commit e3e3617998db8dcd028fce3f26bfddcc14826a6e

  • Provide version information for Mojo by pasting the output of mojo -v`
❯ mojo --version
mojo 25.1.0.dev2025013005 (c228c3f1)
  • Provide Magic CLI version by pasting the output of magic -v

magic does not have a -v flag, but does have a --version flag:

❯ magic --version
magic 0.6.4 - (based on pixi 0.40.3)
@gnodar01 gnodar01 added the bug Something isn't working label Jan 30, 2025
@ehsanmok
Copy link
Contributor

Thanks! this is known. We're fixing the packaging. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants