-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manager customization — TVs cause right sidebar to explode #13977
Comments
@Rainbowtiger screenshots return a 404 |
You caught me during an edit. They work now. |
This should be able to be fixed with Update |
@digitalpenguin @Rainbowtiger Side thought - I wonder if TV's in the They looked naked dropped in on a grey background. |
True.. Though it would need some logic to add a wrapper panel if there are elements there and hide it if not. |
@digitalpenguin - that's possible already via FC. the new regions are called |
Hmmm I only tried with a listbox type which didn't appear for me. Could you try one of those too? |
It works, but the width escapes outside of the browser window making it impossible to use reliably. |
I've tested the following TV's in
|
@digitalpenguin did you try and fix this "in browser" or did you build the MODX 3 css locally? |
Hi @jonleverrier , I didn't build it I just added the rules into the built css file to test it. It's worth noting that the CSS rule I wrote above is specific to the List Box and other types would need their own. |
I wonder if issue #11856 is related. Are we seeing fields overlap their container because the width of the fields are set to 400px? |
@jonleverrier Yes, it's related. I've tried to fix, but the first attempt was unsuccessful. |
I know this is pretty old but wanted to chime in with the reason this and other field control issues are so difficult to remedy. In many places, MODX's forms are built in a bit of a non-ideal way—taking field components out of the Ext ecosystem and rendering them to the DOM. This is one of those areas. Had resource TV fields been added to the panel(s) by creating their respective Ext components instead of rendering and/or replacing blocks of html, the movement and display of these fields would be much more reliably dealt with. I've begun to tackle this issue in the realm of TV creation via PR #15773 and will look to do the same with how the created TVs are rendered into the resource form, but that will take a little time, especially when it comes to reviewing what will be major changes. The gist of what needs to happen is to:
In addition to fixing the issue identified here, other issues such as #15806 would be easily solved. |
Summary
Placing TVs in the right sidebar of the Document tab don't conform to the width of this column
Step to reproduce
Create TV of type "Listbox".
Observed behavior
If placed in the "modx-resource-main-right" Region, TV sits below the three widgets, but not at the right width:
If placed in the "modx-resource-main-right-bottom" Region, TV sits inside the third widget, but still doesn't conform to the width:
Expected behavior
TV widths should be determined by the column they occupy.
Environment
MODX 3.0.0 alpha
The text was updated successfully, but these errors were encountered: