Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not call installSubscriptionHandlers when serverOptions.subscriptions is false #64

Closed
silvacpp opened this issue Feb 21, 2020 · 1 comment
Closed

Should not call installSubscriptionHandlers when serverOptions.subscriptions is false #64

silvacpp opened this issue Feb 21, 2020 · 1 comment

Comments

@silvacpp
Copy link

image
As shown in the apollo server options, subscriptions can be false and if was, installSubscriptionHandlers could not be called.
If called an exception is thrown
image
@Kauabunga Kauabunga mentioned this issue May 26, 2020
Merged
icebob added a commit that referenced this issue May 29, 2020
@icebob
Merge pull request #76 from Kauabunga/fix/avoidSubscriptionsInstallWh…
73f9101 
…enDisabled

[fix issue #64] No longer installing subscription handlers when disabled
@icebob icebob closed this as completed Jun 3, 2020
@icebob
Copy link
Member

icebob commented Jun 3, 2020

Released in 0.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icebob @silvacpp