Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As dev/ops I want more control over the proxy config #298

Open
jvanveen opened this issue May 7, 2020 · 1 comment
Open

As dev/ops I want more control over the proxy config #298

jvanveen opened this issue May 7, 2020 · 1 comment

Comments

@jvanveen
Copy link
Contributor

jvanveen commented May 7, 2020

Which chart are you referring?

molgenis-frontend

How to reproduce

I would like the option to customize the content of a config file. For instance, in lifelines-webshop/values.yaml, I want to add custom.conf like:

custom: |-
  location /edge-server/ {
    proxy_pass http://lifelines-edge/edge-server/;}
  location /vuepdf {
     proxy_pass http://vue-pdfium/vuepdf;}
  location /vuepdf-dev {
     proxy_pass http://vue-pdfium/vuepdf-dev/;}

Notice the missing trailing slash in location /vuepdf.
Currently, the config can only be defined like:

custom:
    - path: "edge-server"
      url: "http://lifelines-edge/edge-server"
      unpkg: false
    - path: "vuepdf"
      url: "http://vue-pdfium/vuepdf"
      unpkg: false
    - path: "vuepdf-dev"
      url: "http://vue-pdfium/vuepdf-dev"
      unpkg: false

Which produces proxy config like:

location /vuepdf/ {
   proxy_pass http://vue-pdfium/vuepdf/;}

With the trailing slashes, Nginx makes a 301 redirect from a POST to the proxy, which results in a failing endpoint.

@fdlk
Copy link
Contributor

fdlk commented May 7, 2020

See also #246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants