No release is made on merge with master

[connoratrug]

Which chart are you referring?

molgenis-jenkins

How to reproduce

Merge commit containing Conventional Commit Message containing feat: into master

Expected behavior

A release is made is build is successful

Observed behavior

No release is made (sometimes)

for example: https://jenkins.dev.molgenis.org/blue/organizations/jenkins/molgenis%2Fmolgenis-node-lifelines-edge/detail/master/66/pipeline

[jvanveen]

De vorige build werd getriggered door commit 39a0318. Semantic release maakt vervolgens tijdens het bouwen een release commit(0d6dc2c). De volgende build gaat daarna over commit 39a03185, maar ook over 0d6dc2c(de chore commit). 0d6dc2c had al bij Jenkins bekend moeten zijn.

[connoratrug]

When i look at the webhook settings in de github admin panel i can see lots of hooks where failing , updated the hook url from htttp to https , after this the hooks where successful, but do not know it this is really connected to this issue

[fdlk]

In the build log, it says "Stage "Release: [ master ]" skipped due to when conditional" so I'd think this is an issue in the Jenkins Pipeline changelog condition, which checks all commits instead of the last.
This makes "build this when not [skip ci]" skip the build as soon as one of the merged commits is "[skip ci]"
That's useful when you want to trigger on a changelog [release this] type of tag, you want to trigger then when one of the commits contains the tag. But we negate it and then it means the steps are skipped as soon as one of the commits contains [skip ci]