Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Opus codec? #67

Closed
505e06b2 opened this issue Jul 3, 2022 · 4 comments
Closed

Add support for the Opus codec? #67

505e06b2 opened this issue Jul 3, 2022 · 4 comments

Comments

@505e06b2
Copy link

505e06b2 commented Jul 3, 2022

Just wondering if this has been considered, as Opus is the successor to Vorbis, and hardware decoding does not seem to be a concern for this project. The biggest caveat I can see is that their extensions could be the same (ogg) so would require reading the metadata to determine the correct decoder

Regardless, thanks for all your hard work! I've been using this on and off since at least early 2016 and it has only improved in that time

@mon
Copy link
Owner

mon commented Jul 4, 2022

It's really no problem, aurora.js (the fallback decoder for Safari because Apple hates open codecs) has an opus module that I can include, and it should demux that without any issues.

I'll take a look in the coming weeks to see how easy the integration is.

@mon
Copy link
Owner

mon commented Jul 6, 2022

There is a tentative addition of opus on my own 0x40 - try and load an opus encoded file and see if it works. I really should just get my own opus ogg and test it, but somewhat time poor.

@505e06b2
Copy link
Author

Works for me, though I don't currently have any Apple devices to hand to properly test this codepath (there doesn't seem to be any regressions at least).
I made this quick respack, which should hopefully be of some use - the song is Machineheart + Vanic - Circles: opus_respack.zip

@mon
Copy link
Owner

mon commented Jul 10, 2022

Thanks, nice respack!

I locally forced the fallback codepath and the loop loads fine, no gaps. Decoding is little slower, but that's to be expected. Crazy how small opus encoded audio is...
Fixed in af88533

@mon mon closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants