Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enter/k key behavior like on htop #18

Closed
ghost opened this issue Jul 16, 2016 · 4 comments
Closed

add enter/k key behavior like on htop #18

ghost opened this issue Jul 16, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 16, 2016

Make the enter key show the inspection is not much helpful. If you could trigger with the enter key an right or left menu with the list of commands that are now showed horizontally on the bottom would be more productive.

Rebind i to trigger inspections makes more sense and bind k to stop container would be more fun :)

Besides that everything is perfect ;)

@ghost ghost changed the title add enter behavior like on htop add enter/k key behavior like on htop Jul 16, 2016
@moncho
Copy link
Owner

moncho commented Jul 18, 2016

Thanks, using enter to show a menu with the command list is a great idea.

@moncho
Copy link
Owner

moncho commented Aug 7, 2016

Hey @vyscond

A menu for container commands has been added, available pressing [Enter]. It has not been implemented exactly as you proposed it, but the basic idea is quite the same I would say.

Inspect has been rebind to [i]. Rebinding kill to [k] seems a bit dangerous, one wrong click and you have killed a running container (which might or might not be so fun, depending on how much you liked the container :).

It would be really helpful if you could take a look and provide some feedback.

Available on version v0.6-alpha.1.

@ghost
Copy link
Author

ghost commented Aug 8, 2016

@moncho thanks for taking the request mate! I see your point for the k bind. I thought about the UX used on the htop maybe? Pressing the key and actually open the left/right menu with the respective command selected? Anyhow this not a critical issue.

I will try the alpha this days and give you feedback ASAP.

@ghost
Copy link
Author

ghost commented Aug 9, 2016

@moncho I tested you update today. Pretty rad! Thanks for implement the feature :3

@moncho moncho closed this as completed Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant