Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: codemirror extension to automatically insert matching tag name once closed #44

Merged
merged 15 commits into from
Mar 18, 2024
Merged

feat: codemirror extension to automatically insert matching tag name once closed #44

merged 15 commits into from
Mar 18, 2024

Conversation

YossiSaadi
Copy link
Contributor

https://monday.monday.com/boards/3532714909/pulses/6260142723

e.g. typing <Button and then adding > would result in <Button></Button>
same for if the component has props, etc.

YossiSaadi added 14 commits March 14, 2024 17:31
@YossiSaadi
docs(README): fix import path
9ea0a22
@YossiSaadi
feat: add autocomplete abilities for the playground editor
30c642a
@YossiSaadi
style(Editor): style CodeMirror's autocomplete dialog
faa6484
@YossiSaadi
feat(generate-autocompletion): export a script to generate autocomple…
6a6280c 
…tion metadata based on a react-docgen output
@YossiSaadi
fix: description is optional
0c0a635
@YossiSaadi
docs: add autocompletions example for addon's storybook
e00aace
@YossiSaadi
feat: export generateAutocompletion function for addon consumers
6eb2b9a
@YossiSaadi
docs: update README with autocompletions example
217fbdb
@YossiSaadi
docs: fix generateAutocompletion path
31a7505
@YossiSaadi
docs: fix readme
be79ddd
@YossiSaadi
chore: remove console log
1a6e6ff
@YossiSaadi
refactor: change name for getter function
3b88b3f
@YossiSaadi
docs: change README about parameters to be more clear
3469231
@YossiSaadi
feat: codemirror extension to automatically insert matching tag name …
65df32c 
…once closed

e.g. <Button> would result in <Button></Button>
@YossiSaadi YossiSaadi requested a review from a team March 17, 2024 20:30
Base automatically changed from Playground---add-autocomplete-functionality-6041408268 to master March 18, 2024 12:32
@YossiSaadi
Merge branch 'master' into Create-a-CodeMirror-closing-bracket-extens…
6b6003e 
…ion-6260142723

# Conflicts:
#	src/codemirror/extensions/autocomplete.ts
#	src/components/Addons/Panel.tsx
#	src/types.ts
#	tsconfig.json
@YossiSaadi YossiSaadi merged commit 658ade1 into master Mar 18, 2024
4 checks passed
@YossiSaadi YossiSaadi deleted the Create-a-CodeMirror-closing-bracket-extension-6260142723 branch March 18, 2024 16:22
github-actions bot pushed a commit that referenced this pull request Mar 18, 2024
@semantic-release-bot
chore(release): set package.json to 1.5.0 [skip ci]
3306dd2 
# [1.5.0](v1.4.1...v1.5.0) (2024-03-18)

### Features

* codemirror extension to automatically insert matching tag name once closed ([#44](#44)) ([658ade1](658ade1))
* codemirror extension to automatically insert self closing tag once closed ([#45](#45)) ([929a9fc](929a9fc))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talkor talkor talkor approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YossiSaadi @talkor