Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Dropdown />'s Border Bottom Hidden #351

Open
chris-packett opened this issue Nov 20, 2021 · 3 comments
Open

<Dropdown />'s Border Bottom Hidden #351

chris-packett opened this issue Nov 20, 2021 · 3 comments
Labels

Comments

@chris-packett
Copy link

chris-packett commented Nov 20, 2021

Firstly, thank you for creating an awesome UI component library; it's saved us a ton of time.

We are using the component in our application and we are experiencing something a bit odd with the styling.

When I zoom out to 80% in Chrome, the component's bottom border is hidden. See "Customer Name" in the screenshot below:
image

Note: The "Terms" field is also using the component--but is not having any bottom border rendering issues.

The "Terms" dropdown starts having bottom border rendering issues at 75%:
image

However, when I zoom out to only 90%, the component's bottom border is visible again:
image

This seems to be happening in the storybook, as well (at 75% zoom):
image

I dug through the styles a bit but had no luck finding the issue.

Note: This does not seem to be happening on React Select's component at any zoom (I tried 100%, 90%, 80%, 75%, 66%, all the way down).

@orrgottlieb
Copy link
Contributor

Hi @chris-packett
Thank you so much for the issue - I see that the height calculation is a bit smaller -
image

did you try it on other Chrome versions or other browsers?

@chris-packett
Copy link
Author

chris-packett commented Nov 27, 2021

Hi @chris-packett Thank you so much for the issue - I see that the height calculation is a bit smaller - image

did you try it on other Chrome versions or other browsers?

@orrgottlieb Yes, this is also happening on Safari & Firefox.

@mSaurabh
Copy link

@talkor Does this issue still need to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants