From e6e98a4c73867d73626493bbc1d524d4a9c166ed Mon Sep 17 00:00:00 2001
From: Alena Khineika <alena.khineika@gmail.com>
Date: Thu, 25 Jan 2024 15:55:41 +0100
Subject: [PATCH 1/2] feat(NODE-3034): deprecate number as an input to ObjectId
 constructor

---
 src/objectid.ts           | 43 ++++++++++++++++++++++++++++++++++++---
 test/types/bson.test-d.ts |  7 ++++++-
 2 files changed, 46 insertions(+), 4 deletions(-)

diff --git a/src/objectid.ts b/src/objectid.ts
index 372b08d8..e35fa8cc 100644
--- a/src/objectid.ts
+++ b/src/objectid.ts
@@ -44,9 +44,46 @@ export class ObjectId extends BSONValue {
   private __id?: string;
 
   /**
-   * Create an ObjectId type
+   * Create ObjectId from a number.
    *
-   * @param inputId - Can be a 24 character hex string, 12 byte binary Buffer, or a number.
+   * @param inputId - A number.
+   * @deprecated Instead, use `static createFromTime()` to set a numeric value for the new ObjectId.
+   */
+  constructor(inputId: number);
+  /**
+   * Create ObjectId from a 24 character hex string.
+   *
+   * @param inputId - A 24 character hex string.
+   */
+  constructor(inputId: string);
+  /**
+   * Create ObjectId from the BSON ObjectId type.
+   *
+   * @param inputId - The BSON ObjectId type.
+   */
+  constructor(inputId: ObjectId);
+  /**
+   * Create ObjectId from the object type that has the toHexString method.
+   *
+   * @param inputId - The ObjectIdLike type.
+   */
+  constructor(inputId: ObjectIdLike);
+  /**
+   * Create ObjectId from a 12 byte binary Buffer.
+   *
+   * @param inputId - A 12 byte binary Buffer.
+   */
+  constructor(inputId: Uint8Array);
+  /**
+   * Implementation overload.
+   *
+   * @param inputId - All input types that are used in the constructor implementation.
+   */
+  constructor(inputId?: string | number | ObjectId | ObjectIdLike | Uint8Array);
+  /**
+   * Create a new ObjectId.
+   *
+   * @param inputId - An input value to create a new ObjectId from.
    */
   constructor(inputId?: string | number | ObjectId | ObjectIdLike | Uint8Array) {
     super();
@@ -65,7 +102,7 @@ export class ObjectId extends BSONValue {
       workingId = inputId;
     }
 
-    // the following cases use workingId to construct an ObjectId
+    // The following cases use workingId to construct an ObjectId
     if (workingId == null || typeof workingId === 'number') {
       // The most common use case (blank id, new objectId instance)
       // Generate a new id
diff --git a/test/types/bson.test-d.ts b/test/types/bson.test-d.ts
index 6addcc5e..c0e46bac 100644
--- a/test/types/bson.test-d.ts
+++ b/test/types/bson.test-d.ts
@@ -1,4 +1,4 @@
-import { expectType, expectError } from 'tsd';
+import { expectType, expectError , expectDeprecated, expectNotDeprecated } from 'tsd';
 import {
   Binary,
   Code,
@@ -10,6 +10,7 @@ import {
   MaxKey,
   MinKey,
   ObjectId,
+  ObjectIdLike,
   BSONRegExp,
   BSONSymbol,
   Timestamp,
@@ -77,3 +78,7 @@ expectType<'Binary'>(UUID.prototype._bsontype)
 declare const bsonValue: BSONValue;
 expectType<string>(bsonValue._bsontype);
 expectType<(depth?: number | undefined, options?: unknown, inspect?: InspectFn | undefined) => string>(bsonValue.inspect);
+
+expectNotDeprecated(new ObjectId('foo'));
+expectDeprecated(new ObjectId(42));
+expectNotDeprecated(new ObjectId(42 as string | number));

From b50469de6aafc347ffd1b9efa231e7ea6626254c Mon Sep 17 00:00:00 2001
From: Alena Khineika <alena.khineika@gmail.com>
Date: Fri, 26 Jan 2024 12:48:05 +0100
Subject: [PATCH 2/2] feat: add a constructor overload with no arguments

---
 src/objectid.ts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/objectid.ts b/src/objectid.ts
index e35fa8cc..a1a46f4e 100644
--- a/src/objectid.ts
+++ b/src/objectid.ts
@@ -74,6 +74,8 @@ export class ObjectId extends BSONValue {
    * @param inputId - A 12 byte binary Buffer.
    */
   constructor(inputId: Uint8Array);
+  /** To generate a new ObjectId, use ObjectId() with no argument. */
+  constructor();
   /**
    * Implementation overload.
    *