Update CRUD Tests #1622
Merged
Update CRUD Tests #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 19, 2017 17:41
an object, not an array, is now returned
|
@jlord and I spoke offline about this, my general comments are that we need update the inline documentation, and also update the migration guide indicating that this is a breaking change |
daprahamian
suggested changes
Dec 20, 2017
lib/collection.js
Outdated
| @@ -724,7 +714,7 @@ define.classMethod('bulkWrite', { callback: true, promise: true }); | |||
| * @typedef {Object} Collection~insertWriteOpResult | |||
| * @property {Number} insertedCount The total amount of documents inserted. | |||
| * @property {object[]} ops All the documents inserted using insertOne/insertMany/replaceOne. Documents contain the _id field if forceServerObjectId == false for insertOne/insertMany | |||
| * @property {ObjectId[]} insertedIds All the generated _id's for the inserted documents. | |||
| * @property {ObjectId[]} insertedIds Map of the index of the inserted document to the id of the inserted document. | |||
There was a problem hiding this comment.
We should change the jsdoc type to {Object.<string, ObjectId}
There was a problem hiding this comment.
agreed, but I think its actually {Object.<Number, ObjectId>}
mbroadst
approved these changes
Dec 20, 2017
daprahamian
approved these changes
Dec 20, 2017
|
@jlord this needs to be rebased |
This was referenced Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CRUD tests in these ways:
bulkWriteto pass onarrayFiltersinsertManyto returninsertedIdsin the correct formatbulkWrite,insertOneandinsertManyFor review ease, skip the first commit which dumps the new files in ✨
🍍
NODE-1228