Resync Connection String Spec Tests #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprahamian
reviewed
Jan 30, 2018
| try { | ||
| result = parser.parse(url, true); | ||
| } catch (e) { | ||
| return callback(new Error('URL malformed, cannot be parsed')); |
There was a problem hiding this comment.
Do we want to add any specific error on how the url is malformed?
There was a problem hiding this comment.
The original error from Node doesn't tell us that so we can't pass that info on, so we'd have to check ourselves for each possible type of error to relay how it was wrong which seems like a lot of work.
mbroadst
approved these changes
Jan 30, 2018
This was referenced Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest tests from the connection string spec and fix our url parser so that it handles errors that come from Node's
url.parsewhen given a bad uri.The error message uses 'malformed' because this is how the original Node error describes it.
Fixes NODE-1292