Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: internal access modifier on symbol properties #2664

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 7, 2020

The process of rolling up the definitions into one file and removing the internal APIs left some typescript errors in the final definitions file, these changes fix the errors. In addition this adds a step to the check:lint script to ensure errors don't exist in the produced definitions file.

@nbbeeken nbbeeken requested review from emadum and mbroadst December 7, 2020 17:50
@nbbeeken
Copy link
Contributor Author

nbbeeken commented Dec 7, 2020

My original solution marked the properties on OperationParent as internal, freeing the implementers to do the same. However, I thought it better that the public classes don't implement it at all, there will still be the type checking we want, when you pass a Db for example to an operation that accepts OperationParent it will fail if Db changes to a nonconformant shape.

Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit f6d9b81 into master Dec 7, 2020
@nbbeeken nbbeeken deleted the chore/fix-access branch December 7, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants