feat(NODE-3115): Add generic parameterization #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
Mar 25, 2021
nbbeeken
force-pushed
the
NODE-3115/ts-generics
branch
from
271ce21 to
16f0df0
Compare
durran
requested changes
Apr 9, 2021
nbbeeken
force-pushed
the
NODE-3115/ts-generics
branch
from
98135ef to
b7fce6b
Compare
nbbeeken
force-pushed
the
NODE-3115/ts-generics
branch
from
b7fce6b to
1de5be6
Compare
MongoClient, Db, Collection, and Cursors can now accept generic parameters to type check the usage of the various API methods on each class. Using generics is kept optional.
…emove abstract cursor generic constraint
nbbeeken
force-pushed
the
NODE-3115/ts-generics
branch
from
1de5be6 to
2136bdf
Compare
dariakp
requested changes
May 11, 2021
PaulEndri
reviewed
May 12, 2021
dariakp
requested changes
May 14, 2021
src/change_stream.ts
Outdated
| const stream = changeStream[kCursorStream] || cursor.stream(); | ||
| changeStream[kCursorStream] = stream; | ||
| stream.on('data', change => processNewChange(changeStream, change)); | ||
| stream.on('error', error => processError(changeStream, error)); | ||
| } | ||
|
|
||
| function endStream(changeStream: ChangeStream): void { | ||
| function endStream(changeStream: ChangeStream<any>): void { |
There was a problem hiding this comment.
Should this one also be typed or is it an intentional omission?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Generics to Typescript Code
Building upon the splendiferous efforts in the community typings, I've brought inhouse the functionality to create collections across a typescript type. Please see the comments I'll post in short order for implementation details.
It's worth calling out: This does not enable runtime type checking, or BSON to class mapping.
NODE-3115