Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4496): counter values incorrecly compared when instance of Long #3342

Merged
merged 7 commits into from
Aug 8, 2022
Merged

fix(NODE-4496): counter values incorrecly compared when instance of Long #3342

merged 7 commits into from
Aug 8, 2022

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Aug 1, 2022

Description

What is changing?

  • Correct the issue with the long check and comparison using the wrong value.
  • Clarify variable ordering with better naming
  • Bring in spec docs for comparison
  • Mark other places of Long BSON related issues
  • Add unit tests passing both numbers and Longs into comparison function

What is the motivation for this change?

Fix comparison bug

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from dariakp August 2, 2022 17:17
@nbbeeken nbbeeken marked this pull request as ready for review August 2, 2022 17:18
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 2, 2022
dariakp
dariakp requested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to not have lint/unit test failures here

@nbbeeken nbbeeken force-pushed the NODE-4496/processId-comparison branch from b13a851 to 2f48382 Compare August 4, 2022 14:55
@nbbeeken nbbeeken requested a review from dariakp August 4, 2022 17:35
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 4, 2022
dariakp
dariakp requested changes Aug 4, 2022
View reviewed changes
src/sdam/server_description.ts Show resolved Hide resolved
src/sdam/server_description.ts Outdated Show resolved Hide resolved
test/unit/sdam/server_description.test.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken requested a review from dariakp August 4, 2022 19:09
dariakp
dariakp requested changes Aug 4, 2022
View reviewed changes
test/unit/sdam/server_description.test.ts Show resolved Hide resolved
test/unit/sdam/server_description.test.ts Outdated Show resolved Hide resolved
@durran durran merged commit d29eb8c into main Aug 8, 2022
@durran durran deleted the NODE-4496/processId-comparison branch August 8, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp requested changes

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @durran @dariakp