-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-4998): use ipv4 in socks5 tests for node 18 #3538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the two tasks are
- socks5 tests only
- socks5 tests and csfle + socks5 tests
We want to break them apart entirely, so
- one task for socks5 driver tests
- one task for csfle tests w/ socks5 enabled
Ah good catch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional change - we could break apart the auth tests too, and have four total tasks here
- socks5 no auth
- socks5 auth
- csfle socks5 no auth
- csfle socks5 auth
I'm partial to this because I when evergreen shows the results of the test run (which it doesn't if you have multiple test runs in a task), but this is an optional change
Maybe a new ticket for that effort? |
Description
What is changing?
What is the motivation for this change?
Green ci
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript