Dates of activities save as 1 day previous

[jyrodgers]

(Note: you don't need to follow this template, nor to keep headlines or bold sentences - they are just there to guide you. Feel free to delete everything. We review every issue even if we don't immediately respond.)

Thanks for filing an issue and for your interest in the project.

Describe the bug
When I enter an activity with a contact and save it, the date on the date of that activity in the log is for the previous day. Example: If I enter the date of the activity as 2018-10-17 the activity in the log is 2018-10-16.

Screenshots

Which version are you using:

• Hosting version on https://app.monicahq.com

[djaiss]

Oh I see what's going on here.
The date is correctly saved but timezone is taken into account when displaying the information - which is wrong somehow. We need to fix this.

[tbirrell]

There are two viable solutions to this problem as I see it.

1. Stop using DateHelper in activity/index.blade.php.
2. Refactor DateHelper to allow skipping the TZ check for the various methods

The first option fixes the immediate problem, though perhaps at the detriment of consistency.

The second option would look something like:

public static function getShortDate($date, $faceValue = false)
{
    $date = new Date($date, ($faceValue ? null : static::getTimezone()));
    $format = trans('format.short_date_year', [], Date::getLocale());

    return $date->format($format) ?: '';
}

If we went that route, this should be done to all the DateHelper methods for consistency's sake and would default to existing behavior, so should not affect anything. But it would allow us to display the datetimestamps at face value when necessary.

[johnriley]

Any update on this?

[danielbachhuber]

I've seen this issue too!

To confirm, the date stored is correct, but the display date is incorrect? If this is the case, then I'm experiencing #2192 too.

[github-actions]

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.