Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact creation form on "Person not found" doesn't work #2464

Closed
mechanarchy opened this issue Feb 20, 2019 · 1 comment · Fixed by #2468
Closed

Contact creation form on "Person not found" doesn't work #2464

mechanarchy opened this issue Feb 20, 2019 · 1 comment · Fixed by #2468
Assignees
Labels

Comments

@mechanarchy
Copy link

Problem
If you try to go to a contact page that no longer exists, you'll be redirected to /people/notfound. This page suggests that you add a new contact, using a form like this:

image

Trying to create a contact using this form doesn't work, and it also doesn't allow you to select any custom genders. I suspect this bug was introduced in #879 or a related change.

The standard form for adding new contacts (at /people/add) looks like this:

image

Suggested resolution

I'd suggest that the /people/notfound page should display the same form as /people/add, and the old form code is removed.

As a quicker alternative, the people/notfound page could have no form and instead a link that redirects you to /people/add.

@github-actions
Copy link

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants