feat: add Apple icons for use when bookmarking. #4743
Conversation
This commit replaces the icons from the previous with ones with a solid white background and no text. I've optimised these in terms of filesize as much as possible.
There was a problem hiding this comment.
Some remarks:
- Do we need to add these 11 image files? All of them are not used in the skeleton blade file.
- I don't agree with the names of the files, which don't apply to apple only.
- It would be better to use the logo image (you used it in
apple-icon.pngfile), without the "Monica" name
asbiin
changed the title
|
Hi Alexis, Thanks for the feedback. I’ve updated the code and made a new commit to address your comments. To respond to them directly:
No. I've slimmed this down to four images now —- most of the smaller images were for older devices that are unlikely to be in wide use now.
These are explicitly used for Apple devices, hence the (now amended) filenames and the very specific icon sizes. I've worked on this revised commit based on the explanation in this Apple guide. I'm researching how to do this for Android devices too, and will submit this as a new pull when I've worked it out.
It looks like the icons I intended to include in the third commit didn't get included. This is fixed, and they're all the same: white background with just the logo on it. I've also added another line so that it defaults to the name 'Monica' when added to the home screen as a web app (line 19). Hope this is satisfactory. |
|
I’ve just seen issue #4564. This pull request would resolve that issue. |
|
When naming the files, I followed the Apple documentation’s recommendations. I’m not sure what effect it would have giving them different filenames. |
|
Great! Thank you @mgrhm |
|
This pull request has been automatically locked since there |
Adds icons for when Monica is added as a bookmark to the home screen on an iOS device. Currently, it defaults to a miniaturised screenshot.