feat: order introductions contact list by first and last name

[iloveitaly]

It's feels much more natural to me to order the introductions list by first and last name.

Checklist

Before submitting the PR

• Read the CONTRIBUTING document before submitting your PR.
• If the PR is related to an issue or fix one, don't forget to indicate it.
• Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

• Make sure that the change you propose is the smallest possible.
• The name of the PR should follow the conventional commits guideline that the project follows.

Other tasks

• CHANGELOG entry added, if necessary, under UNRELEASED.
• CONTRIBUTORS entry added, if necessary.
• If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
• Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

[djaiss]

Hi @iloveitaly and thanks for the PR.

To you it might feel more natural, but in other cultures, it might not.

This is why we introduced the column called name_order in the users table that define how people want their contact to be sorted.

I think we should use this in this case, what do you think @asbiin ?

[iloveitaly]

Ah, great, didn't realize there was an option for that. It sounds like we should add a switch similar to this one to add 2-3 orderBys to the query. I'm not that familiar with the codebase—where would be the best place for this helper?

[djaiss]

Ah, great, didn't realize there was an option for that. It sounds like we should add a switch similar to this one to add 2-3 orderBys to the query. I'm not that familiar with the codebase—where would be the best place for this helper?

Good question.
We might need to use this in other places too. So I would perhaps create a ContactHelper with the right method name in it, like getNameInUserOrder or something like this (yes, naming is hard).

[iloveitaly]

@djaiss added a helper to execute this logic. Take a look!

[iloveitaly]

@asbiin Any thoughts on how to fix the typing error? Builder as a param + return type seems to return an error since HasMany is passed in.

[asbiin]

phpstan is complaining, and I think it would be better to use a scope

[github-actions]

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

• GitHub release
• v3.6.0

Your semantic-release bot 📦🚀

[github-actions]

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.