CardDAV includes contacts which aren't 'real' contacts

[cstrat]

This should be a simple fix by filtering, I am surprised it hasn't been raised before.

My iPhone sync's with Monica using CardDAV.
I am seeing names for people I have added - but not created contact cards for.
Example would be the names of children or siblings and parents of friends and associates.

Those names have no data attached, so they shouldn't be fetched by CardDAV for the Sync.

[cstrat]

Does this impact anyone else or just me? Perhaps I've misconfigured something?

I am guessing this is where the issue is - this must just be selecting all contacts in the DB, even those not set as a real contact. Perhaps something is going wrong with what it thinks an active contact is?

monica/app/Http/Controllers/DAV/Backend/CardDAV/CardDAVBackend.php

Lines 235 to 245 in 0ae575f

	/**
	* Returns the collection of all active contacts.
	*
	* @return \Illuminate\Support\Collection
	*/
	public function getObjects($addressBookId)
	{
	return Auth::user()->account->contacts($addressBookId)
	->active()
	->get();
	}

[cstrat]

BTW, this may be intentional, however those same "contacts" appear in the search results in the search bar at the top.
For example this "contact" is the partner of a colleague, I don't want them to appear in my search or as a contact in my phone. I only wanted to keep track of my colleagues partners name so I don't forget.

[github-actions]

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

• GitHub release
• v4.0.0

Your semantic-release bot 📦🚀

[github-actions]

This issue has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.