-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: quick add with email #5182
Conversation
d0ad563
to
e7523ca
Compare
@asbiin this one is ready to go! Want to take a look? |
@iloveitaly I think that's a good idea, however we need to be sure it does downgrade search performances. Is there a index on email on the contacts table? |
@asbiin Doesn't look like it Any issue with adding an index to this table? |
@iloveitaly no, we should add it, that's the idea. |
@iloveitaly don't hesitate if you need help about adding the index |
Thank you @iloveitaly |
@asbiin no problem!! So glad this got merged. One improvement that would be great here is to detect an email-only search entry and use that value for the email field instead of the first name field. |
🎉 This PR is included in version 3.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request has been automatically locked since there |
#5083
Not sure if it's worth writing a test for this case, feel free to point me to an existing one for the quick add parsing and I can update it.
Checklist
Before submitting the PR
General checks
Front-end changes