Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quick add with email #5182

Merged
merged 4 commits into from
Jan 1, 2022

Conversation

iloveitaly
Copy link

@iloveitaly iloveitaly commented May 12, 2021

#5083

Not sure if it's worth writing a test for this case, feel free to point me to an existing one for the quick add parsing and I can update it.

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • If you change the UI, make sure to ask repositories administrators first about your changes by pinging djaiss or asbiin in this PR.
  • Screenshots are included if the PR changes the UI.
  • Front-end tests have been written with Cypress.

@iloveitaly iloveitaly force-pushed the 5083-quick-add-with-email branch from d0ad563 to e7523ca Compare May 24, 2021 14:39
@iloveitaly iloveitaly changed the title WIP feat: quick add with email feat: quick add with email May 24, 2021
@iloveitaly
Copy link
Author

@asbiin this one is ready to go! Want to take a look?

@asbiin
Copy link
Member

asbiin commented Sep 6, 2021

@iloveitaly I think that's a good idea, however we need to be sure it does downgrade search performances. Is there a index on email on the contacts table?

@iloveitaly
Copy link
Author

@asbiin Doesn't look like it

image

Any issue with adding an index to this table?

@asbiin
Copy link
Member

asbiin commented Sep 6, 2021

@iloveitaly no, we should add it, that's the idea.

@asbiin
Copy link
Member

asbiin commented Sep 14, 2021

@iloveitaly don't hesitate if you need help about adding the index

@asbiin asbiin merged commit 80001fc into monicahq:master Jan 1, 2022
@asbiin
Copy link
Member

asbiin commented Jan 1, 2022

Thank you @iloveitaly

@iloveitaly
Copy link
Author

@asbiin no problem!! So glad this got merged. One improvement that would be great here is to detect an email-only search entry and use that value for the email field instead of the first name field.

@github-actions
Copy link

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants