feat: add path style URL support for S3 buckets #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for a lot of people depending on e.g. self-hosted MinIO setups, where virtual-hosted style URLs may not be enabled or supported.
|
|
|
Thank you @Xenthys ! |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have added path style URL support to Monica by adding a single line relying on a new
S3_PATH_STYLEenvironment variable, kept to false by default as to not have any impact whatsoever if left unconfigured of course. This was already supported by the underlying S3 library so the edit was quite trivial.This is necessary for a lot of people depending on e.g. self-hosted MinIO setups, where virtual-hosted style URLs may not be enabled or supported. This was my case so after a bit of research, I found and added this option. I believe it can help others and won't impact anyone who doesn't explicitly set this to true so… may as well PR it!