feat: searchable contacts on introductions form #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-use the `ContactSelect` component for a searchable contacts dropdown on the `introductions/edit` page. Resolves monicahq#5342
particleflux
force-pushed
the
issue-5342-searchable-contacts-on-introduction-form
branch
from
6b049b1 to
966e984
Compare
|
Added a cypress test. |
|
@particleflux That's great, thank you! |
particleflux
deleted the
issue-5342-searchable-contacts-on-introduction-form
branch
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-use the
ContactSelectcomponent for a searchable contacts dropdownon the
introductions/editpage.Resolves #5342
@djaiss This is technically a UI change - PR info said to ping one of you
Here is the new dropdown (same as for relationship creation, including same default list, and same sorting):
Still have to dig into getting Cypress to run - will try to add some browser-tests for this - drafting this PR for now