feat: add reminders/upcoming API
#5783
Conversation
| public function upcoming(Request $request, int $month = 0) | ||
| { | ||
| try { | ||
| $reminders = AccountHelper::getUpcomingRemindersForMonth( | ||
| auth()->user()->account, | ||
| $month | ||
| )->pluck('reminder'); | ||
| } catch (QueryException $e) { | ||
| return $this->respondInvalidQuery(); | ||
| } | ||
|
|
||
| return ReminderResource::collection($reminders); | ||
| } |
There was a problem hiding this comment.
I'm thinking about copy content of AccountHelper::getUpcomingRemindersForMonth() to here,
and replace ->get() with ->pagination().
But it's more complicated, and ?limit=xxx not work correctly as I expected.
So I create simple PR like this, get all upcoming event in target month.
If anyone have better idea, feel free to tell me.
nhymxu
force-pushed
the
api-reminders-upcoming
branch
from
5fd0b0e to
b36da13
Compare
nhymxu
force-pushed
the
api-reminders-upcoming
branch
from
b36da13 to
ca9e9ce
Compare
|
@asbiin About your comment, please consider my idea. Thank you |
|
🎉 This PR is included in version 3.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Close #5778
Docs close monicahq/marketing_site#642
General checks
Backend/models changes
Usage
current monthor
next month(month+1)next n month(month+n)