fix: check male translation and fall back to generic

[codemonkeysoftware]

Right now relationship type strings do not display a male version (eg. instead of "father" it displays parent). This is because the RelationshipType's getLocalizedName() code gets the female translation for female relationship types, but the generic translation for male relationship types. To complicate matters, only 13/28 relationship types include a male entry in the translation file.

This change has RelationshipType.getLocalizedName() return the male translation for the male version and adds the missing male translations for English. Because I don't want this change to break if the other translations don't get updated with the new keys immediately, it also includes a fallback that recognizes Laravel's default return for missing keys (which is the requested key name) and instead returns the generic translations. This fallback can be removed as soon as the male translation entries get added.

Fix #5956

[asbiin]

Thank you

[J4NS-R]

@asbiin @codemonkeysoftware What's the hold-up here? StyleCI has a small whitespace issue, but other than that this bugfix looks good to go

[asbiin]

Thank you @codemonkeysoftware !

[shaliru]

Sorry for stupid question, but how do I go about applying this fix to my installation? I'm on the latest version (v3.7.0) which was released in February - before this fix was was merged. Do I just drop the two changed files into my install directory?

[Bodge-IT]

I'm 3.7.0 too, finding it difficult if I can't create proper relationships. I can exec into the container but have no edit tools in there and no clue how to mod an image.

EDIT:
OK, manually applied these changes to my docker container and it had no impact on dropdown options for male relationships.

What am I missing?

[github-actions]

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

• GitHub release
• v4.0.0

Your semantic-release bot 📦🚀

[github-actions]

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.