Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor context fixes #3

Open
monocle opened this issue Dec 21, 2022 · 2 comments
Open

Minor context fixes #3

monocle opened this issue Dec 21, 2022 · 2 comments

Comments

@monocle
Copy link
Owner

monocle commented Dec 21, 2022

  • Home page
    This is a bit out of date and lacks specific reference to "this fight".

image

Could this be auto updated?
image

  • “Manual” page
    Broken Code for PDX link

image

Double reference to MIT license
image

Doubled text and needs space before link
image

Extra period at end of link
image

Target link is being “updated”
image

image

Overview here is h3
image

While other sections are h2
image

image

Should these other sections be h3?

Does not match with in page nav
image

  • “Using” vs “Use”
  • No Overview
  • Here are in page nav links that don’t are in right nav

image

- “complete forms” “obtain fingerprints”
@hmarcks
Copy link

hmarcks commented Dec 31, 2022

Thanks for this @monocle ! Some comments below.


  • Home page
    This is a bit out of date and lacks specific reference to "this fight".
image

Any updates for the banner @michaelzhang43 @wittejm ?


Could this be auto updated? image

I think we purposefully don't track results in the app but we have an email newsletter with a Google survey where partners submit their numbers that we could potentially hook up to, but Michael may want to double check those submissions and may not be worth the effort anyway.


  • “Manual” page
    Broken Code for PDX link
image

👍 should be https://www.codeforpdx.org/


Double reference to MIT license image

Can probably remove the second reference as I assume it falls under the "codebase" but also fine to leave as is


Doubled text and needs space before link image

👍


Extra period at end of link image

👍


Target link is being “updated” image

image

I think we should keep this as is, hopefully they will update it soon


Overview here is h3 image

While other sections are h2 image

image

Should these other sections be h3?

"Overview" h3 is a sub heading inside "Using RecordSponge" h2, so that's why it's h3. It's a bit weird because it's the only sub heading but I think it's fine to leave as is.


Does not match with in page nav image

  • “Using” vs “Use”

Let's use "Use" in the heading


  • No Overview

Overview is a sub header so this is okay


  • Here are in page nav links that don’t are in right nav
image
- “complete forms” “obtain fingerprints”

I think the sections are short enough not to include the sub headings in the main nav, but it wouldn't hurt to add them

@monocle
Copy link
Owner Author

monocle commented Jan 3, 2023

Thanks for taking a look at this! I'll get it added to the other changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants