-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add url routing - open scripts from browser location url #70
Comments
i believe implementing this requires the introduction of a "router" (possibly https://reacttraining.com/react-router/) and as a result there are some potentially non-trivial changes to the application to make it work - but definitely doable. |
what are all the routes we want? Ideas:
|
@ngwese : what were you thinking about norns docs (api, etc)? some way to read docs inline would be great imo. if we did that maybe another route there? otherwise, maybe routes for the |
currently the only defined routes are:
the above suggestions for as far as how the docs/reference get integrated i haven't thought too far ahead. i don't personally have a strong desire to see a ton of documentation hosted directly from the device for space and for maintenance reasons. i do think it is useful to imagine some level of api documentation integrated into the editor (particularly for the lua code which not directly visible in the editor). |
thanks for the clarification (also I'll check out the doc endpoint, didn't realize that was a thing). I've updated my comment. |
What are the opinions on this now? Specifically I'm wondering what the static paths would look like. I'm thinking below |
Support for script URLs is now in master thanks to @ryanlaws |
and update the location url when a script is opened from the editor.
The text was updated successfully, but these errors were encountered: