Array.prototype is modified

[thanpolas]

I had an issue (verbling/assetflow#10) in one of my libraries, were a developer has conflict problems because Collections alters the Array.prototype. I am quoting @Amptron:

Collections JS adds some methods to the Array.prototype. Since this added functionality doesn't seem to be an explicit intention of assetflow, it seems weird to have it as a dependency.

Specifically, we're using Sugar JS and Collection's Array.find method collides with Sugar's Array.find which is an unintended consequence of using assetflow.

  assert = require('assert');

  assert.equal(Array.prototype.find, void 0, "Prototype modified before assetflow");

  require('assetflow');

  assert.equal(Array.prototype.find, void 0, "Prototype modified after assetflow");

Output: Prototype modified after assetflow

What do you suggest the best course of action should be?

[Stuk]

@thanpolas Just FYI it's defined here, and is needed by a number of collections, so it's not a simple matter of just replacing it. In the short term your user could overwrite it themselves to accept a function or a value to maintain the needed compat. Obviously far from ideal.

@kriskowal collections' Array#find does not align with the ES6 spec's. Sugar JS's is closer. From a collections point of view it should be changed, although this is going to cause problems with FRB.

[kriskowal]

@Stuk looks like I guessed wrong on the direction they were going to take. I’m okay with renaming our find and findLast to findValue and findLastValue and propagating the changes outward.

[kriskowal]

We have corrected our find and findIndex shims in the v2 branch. Alas that this is as soon as we can fix the problem, and that v2 is not ready for prime time. However, no further work needed on this ticket.