Should we revert on zero input

[MathisGD]

We revert when the input is zero, but we don't if the computed shares (resp. amount) is zero. Should we do it ? (it might be quite ugly)

See also #408

[MathisGD]

Note that an other possibility (other than keeping the current code) would be to no longer revert on zero input.

NB: it gives a simple way to accrueInterest (after #405)

[MathisGD]

For exemple ERC20 are not supposed to revert on transfer zero

Note Transfers of 0 values MUST be treated as normal transfers and fire the Transfer event.

https://eips.ethereum.org/EIPS/eip-20#transfer

[MathisGD]

After thinking about it, I don't think that we should revert. I don't see why we should revert on supplying a >0 amount that result in zero added shares / borrowing a >0 shares that result in a zero added amount.

But I have a new question: should we revert on zero inputs?

[MathisGD]

#410

[makcandrov]

Indeed, we seem to be facing this issue again.

[MathisGD]

Not exactly I'm only asking if we should revert on input (0,0)

[Rubilmax]

I have a preference for reverting, but most important to me is to be consistent with #398, #397 and other functions/events

[MathisGD]

Agree

[makcandrov]

Not exactly I'm only asking if we should revert on input (0,0)

It is kind of related. I still think #155 should be reopened.