From 78bbd58423fc8ebfa26c19aca44903cc2e7108c7 Mon Sep 17 00:00:00 2001 From: Chuck Tang Date: Tue, 27 Feb 2024 16:50:05 -0800 Subject: [PATCH 1/4] commit change --- a.yaml | 0 composer/callbacks/oom_observer.py | 2 +- 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 a.yaml diff --git a/a.yaml b/a.yaml new file mode 100644 index 0000000000..e69de29bb2 diff --git a/composer/callbacks/oom_observer.py b/composer/callbacks/oom_observer.py index 87d818df1a..a9511f2c85 100644 --- a/composer/callbacks/oom_observer.py +++ b/composer/callbacks/oom_observer.py @@ -157,7 +157,7 @@ def oom_observer(device: int, alloc: int, device_alloc: int, device_free: int): snapshot_file, trace_plot_file, segment_plot_file, segment_flamegraph_file, memory_flamegraph_file ]: - remote_file_name = (self.remote_path_in_bucket + os.path.basename(f)).lstrip('/') + remote_file_name = os.path.join(self.remote_path_in_bucket, os.path.basename(f).lstrip('/')) log.info(f'Uploading memory visualization to remote: {remote_file_name} from {f}') try: logger.upload_file(remote_file_name=remote_file_name, file_path=f, overwrite=self.overwrite) From ea5731b1f35a84c2eaaebd6233db2ff00146d65d Mon Sep 17 00:00:00 2001 From: Chuck Tang Date: Tue, 27 Feb 2024 16:58:10 -0800 Subject: [PATCH 2/4] commit change --- composer/callbacks/oom_observer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer/callbacks/oom_observer.py b/composer/callbacks/oom_observer.py index a9511f2c85..b7e65e9d84 100644 --- a/composer/callbacks/oom_observer.py +++ b/composer/callbacks/oom_observer.py @@ -157,7 +157,7 @@ def oom_observer(device: int, alloc: int, device_alloc: int, device_free: int): snapshot_file, trace_plot_file, segment_plot_file, segment_flamegraph_file, memory_flamegraph_file ]: - remote_file_name = os.path.join(self.remote_path_in_bucket, os.path.basename(f).lstrip('/')) + remote_file_name = os.path.join(self.remote_path_in_bucket, os.path.basename(f)).lstrip('/') log.info(f'Uploading memory visualization to remote: {remote_file_name} from {f}') try: logger.upload_file(remote_file_name=remote_file_name, file_path=f, overwrite=self.overwrite) From 63266dc42b969696d1b4a01f9bd4a2b18d8704a8 Mon Sep 17 00:00:00 2001 From: Chuck Tang Date: Tue, 27 Feb 2024 16:59:16 -0800 Subject: [PATCH 3/4] commit change --- composer/callbacks/oom_observer.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/composer/callbacks/oom_observer.py b/composer/callbacks/oom_observer.py index b7e65e9d84..2cb8ea4ba5 100644 --- a/composer/callbacks/oom_observer.py +++ b/composer/callbacks/oom_observer.py @@ -157,7 +157,9 @@ def oom_observer(device: int, alloc: int, device_alloc: int, device_free: int): snapshot_file, trace_plot_file, segment_plot_file, segment_flamegraph_file, memory_flamegraph_file ]: - remote_file_name = os.path.join(self.remote_path_in_bucket, os.path.basename(f)).lstrip('/') + base_file_name = os.path.basename(f) + remote_file_name = os.path.join(self.remote_path_in_bucket, base_file_name) + remote_file_name = remote_file_name.lstrip('/') # remove leading slashes log.info(f'Uploading memory visualization to remote: {remote_file_name} from {f}') try: logger.upload_file(remote_file_name=remote_file_name, file_path=f, overwrite=self.overwrite) From 35e0942dec00d8a8f10a5e38e331e45c3f96488e Mon Sep 17 00:00:00 2001 From: Chuck Tang Date: Tue, 27 Feb 2024 17:12:28 -0800 Subject: [PATCH 4/4] commit change --- a.yaml | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 a.yaml diff --git a/a.yaml b/a.yaml deleted file mode 100644 index e69de29bb2..0000000000