Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Cannot build for Node 10 #782

Open
cyrussalem opened this issue Jan 28, 2019 · 4 comments
Open

Cannot build for Node 10 #782

cyrussalem opened this issue Jan 28, 2019 · 4 comments

Comments

@cyrussalem
Copy link

When I do an 'npm install', I see the following compile error. It seems that it is due to the fact that the function Nan:ForceSet is now deprecated.

make: Entering directory '/home/smc-dev/github/bacnet-explorer/node_modules/zmq/build'
  CXX(target) Release/obj.target/zmq/binding.o
In file included from ../node_modules/nan/nan.h:190:0,
                 from ../binding.cc:38:
../node_modules/nan/nan_maybe_43_inl.h: In function ‘Nan::Maybe<bool> Nan::ForceSet(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’:
../node_modules/nan/nan_maybe_43_inl.h:88:15: error: ‘class v8::Object’ has no member named ‘ForceSet’
   return obj->ForceSet(GetCurrentContext(), key, value, attribs);

@ersutton
Copy link

ersutton commented Mar 4, 2019

@cyrussalem Have you managed to find a way around this issue? Just stumbled across this myself.

@mischah
Copy link

mischah commented Jul 12, 2019

Node 8 is also affected :(

I’m using nvm to run it with Node 6. But I hope this will be fixed.

@gnomex
Copy link

gnomex commented Jul 24, 2019

I'm using node v10.16.0 with mosca 2.8.3 and it's working

@rssk
Copy link

rssk commented Aug 18, 2019

For others running into this issue, mosca is building 'fine' but has several opt dependencies failing on newer node, namely zmq, leveldown, snappy, and fs-ext.

If you need these, these issues for these failures can be found here
https://github.com/mcollina/ascoltatori

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants