diff --git a/CMakeLists.txt b/CMakeLists.txt index b6ba568..8c46189 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -90,15 +90,12 @@ target_compile_options(${PROJECT_NAME} PRIVATE ${PROJECT_COMPILE_OPTIONS}) target_include_directories(${PROJECT_NAME} PUBLIC $ $) -target_link_libraries(${PROJECT_NAME} PRIVATE fcl) ament_target_dependencies(${PROJECT_NAME} PUBLIC ${THIS_PACKAGE_EXPORT_DEPENDS} ) -ament_target_dependencies(${PROJECT_NAME} SYSTEM - # We don't export these dependencies because their cmake is broken - assimp - QHULL -) +# Private libraries that are not transitively needed by downstream projects +target_link_libraries(${PROJECT_NAME} PRIVATE assimp::assimp fcl ${QHULL_LIBRARIES}) +target_include_directories(${PROJECT_NAME} PRIVATE ${QHULL_INCLUDE_DIRS}) if(BUILD_TESTING) find_package(ament_cmake_gtest REQUIRED) diff --git a/package.xml b/package.xml index dfafaf4..c6a87df 100644 --- a/package.xml +++ b/package.xml @@ -27,7 +27,6 @@ rclcpp eigen_stl_containers console_bridge_vendor - libqhull liboctomap-dev random_numbers resource_retriever @@ -38,6 +37,7 @@ assimp-dev eigen libfcl-dev + libqhull pkg-config libboost-dev libboost-filesystem-dev @@ -48,6 +48,7 @@ libboost-filesystem rosidl_default_runtime libfcl + libqhull ament_cmake_gtest ament_lint_auto