Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration #16

Closed
vmayoral opened this issue Feb 19, 2019 · 7 comments
Closed

Continuous integration #16

vmayoral opened this issue Feb 19, 2019 · 7 comments

Comments

@vmayoral
Copy link
Contributor

@LanderU, I see you fixed CI in https://github.com/AcutronicRobotics/moveit2/tree/master.

I started a branch at https://github.com/AcutronicRobotics/moveit2/tree/ci for making a PR once it was working (now is!). Would you like me to go ahead and cherry-pick all your changes and then submit the PR myself or would you rather like to do it yourself?

@davetcoleman
Copy link
Member

Much needed testing!

@vmayoral
Copy link
Contributor Author

We will also take care of this ticket, work in progress for now.

@vmayoral
Copy link
Contributor Author

vmayoral commented Mar 5, 2019

@LanderU, after a few days of testing, I'd say our CI prototype is ready for a PR. We need to submit only the CI-related changes. Would you like to submit the PR yourself or should I go ahead an do it?

@LanderU
Copy link

LanderU commented Mar 5, 2019

Would you like to submit the PR yourself or should I go ahead an do it?

Feel free to go ahead.

@davetcoleman
Copy link
Member

@mlautman is going to help convert https://github.com/ros-planning/moveit_ci/ to be ros2 compatible. its been a many years effort to build a very comprehensive set of tests for the code base, between myself and @rhaschke

@vmayoral
Copy link
Contributor Author

vmayoral commented Mar 9, 2019

That is great to hear, thanks @davetcoleman. We will monitor the progress and contribute by ensuring we pick this in our hardware tests. To do so more easily, moveit/moveit_resources#24 should probably be considered. It would also help very much getting a unified infrastructure altogether with the hardware CI we are planning.

@ahcorde and @LanderU this will be interesting for you.

@davetcoleman
Copy link
Member

@henningkayser can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants