Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moveit_py: fix function signature formatting #2499

Closed
peterdavidfagan opened this issue Oct 30, 2023 · 2 comments
Closed

moveit_py: fix function signature formatting #2499

peterdavidfagan opened this issue Oct 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@peterdavidfagan
Copy link
Member

peterdavidfagan commented Oct 30, 2023 •
edited
Loading

Description

The moveit_py library currently mixes snake_case and camelCase across its function signatures. It should be the case that all cpp methods are defined in camelCase while all python methods are defined in snake_case.
@peterdavidfagan peterdavidfagan added the bug Something isn't working label Oct 30, 2023
@peterdavidfagan peterdavidfagan mentioned this issue Oct 30, 2023
Merged
6 tasks
@peterdavidfagan
Copy link
Member Author

Addressed in #2177.

@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Oct 30, 2023
@peterdavidfagan
Copy link
Member Author

Note: some formatting exceptions for pybind specific .def are not being caught by clang-tidy:

#2406 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterdavidfagan