Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download ginac/cln archive instead of using git repo #45

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

volkm
Copy link
Contributor

@volkm volkm commented Aug 26, 2024

The git repositories for Ginac and CLN cannot be cloned since 2 weeks and this is the second time there is an issue with the repo. This PR fixes the issue by using the direct download instead.
Disadvantages are:

  • only the latest version is supported for download which means a timely update is required for a new version, and
  • the zipped archive of CLN has no CMake support

@volkm volkm requested a review from sjunges August 27, 2024 07:10
@sjunges
Copy link
Contributor

sjunges commented Aug 27, 2024

Thanks for taking care of this. Maybe add a comment why the git repos have been commented out?

LGTM.

@volkm
Copy link
Contributor Author

volkm commented Aug 27, 2024

Thanks for the quick feedback and the suggestion for better documentation.

@volkm volkm merged commit 935ddc5 into moves-rwth:master Aug 27, 2024
11 checks passed
@volkm volkm deleted the ginac branch August 27, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants