You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, some parts of the code are still using std::cout. We should revise them to use our custom macros such as STORM_LOG_INFO or STORM_PRINT_AND_LOG.
In addition, we opt to use \n instead of std::endl, see PR #178.
The files GradientDescentInstantiationSearcher.cpp and SparseDerivativeInstantiationModelChecker.cpp should be adapted accordingly.
The text was updated successfully, but these errors were encountered:
Hello,
I am Ashish Padhy (Sophomore at Bachelor's) and am kind of beginning my open source journey.
So can you please clarify how to choose the macro to replace std::cout .
Thanks for your help.
PR #277 addressed the two files you mentioned. Someone should check for other misplaces occurences of std::cout
@Shurtu-gal the macros allow us to control the tool output on a global level. For example, we could easily implement a compile-time option that disables all output.
If there are any other source files that require similar enhancements, I'd be very happy to help with them as well :D This issue helped me find a good example of macro use in a mature code base and I am grateful for that experience
Currently, some parts of the code are still using
std::cout
. We should revise them to use our custom macros such asSTORM_LOG_INFO
orSTORM_PRINT_AND_LOG
.In addition, we opt to use
\n
instead ofstd::endl
, see PR #178.The files
GradientDescentInstantiationSearcher.cpp
andSparseDerivativeInstantiationModelChecker.cpp
should be adapted accordingly.The text was updated successfully, but these errors were encountered: