Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cot.verify should cache requests made to Github #331

Closed
JohanLorenzo opened this issue Apr 24, 2019 · 1 comment · Fixed by #332 or mozilla-releng/build-puppet#486
Closed

cot.verify should cache requests made to Github #331

JohanLorenzo opened this issue Apr 24, 2019 · 1 comment · Fixed by #332 or mozilla-releng/build-puppet#486

Comments

@JohanLorenzo
Copy link
Contributor

JohanLorenzo commented Apr 24, 2019

See #330 (review)

We should fix errors like:

2019-04-23T20:16:03    DEBUG -  GET https://github.com/mozilla/application-services/branch_commits/0a49320a24b2fc826f0153c0627baba1aa94d429
2019-04-23T20:16:03    DEBUG -  GET https://github.com/mozilla/application-services/branch_commits/0a49320a24b2fc826f0153c0627baba1aa94d429
2019-04-23T20:16:04    DEBUG -  GET https://github.com/mozilla/application-services/branch_commits/0a49320a24b2fc826f0153c0627baba1aa94d429
2019-04-23T20:16:04    DEBUG -  GET https://github.com/mozilla/application-services/branch_commits/0a49320a24b2fc826f0153c0627baba1aa94d429
2019-04-23T20:16:04    DEBUG -  Status 429
2019-04-23T20:16:05    DEBUG -  Status 429
2019-04-23T20:16:05    DEBUG -  Status 429
2019-04-23T20:16:05    DEBUG -  Status 429
2019-04-23T20:16:05    ERROR - Hit ScriptWorkerException: Bad status 429

One way to solve this is to cache the request made here

html_data = await retry_request(context, url)
. In fact, we don't need to call this URL 4 times in a row.

@JohanLorenzo
Copy link
Contributor Author

For the record, android-components saw about a dozen identical failures, yesterday. For instance: https://tools.taskcluster.net/groups/JpNiL1RTQau4tf_yYnMriA/tasks/Mj94usLBTo-vXnvL-gQ8YA/runs/1/logs/public%2Flogs%2Fchain_of_trust.log#L105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant